Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more accidental issues! #2966

Closed

Conversation

Navid200
Copy link
Collaborator

@Navid200 Navid200 commented Jul 26, 2023

Before:
Screenshot 2023-07-25 201650

Edit: This is not valid anymore. Please see the post after the next commit to see the latest.
After:
Screenshot 2023-07-25 201831

This PR removes the ability to open a new issue as you can see in the above images.
However, all the existing issues will still be there and visible to all.

@Navid200
Copy link
Collaborator Author

Users will still be able to create an issue from a discussion when instructed by a developer.

@Navid200
Copy link
Collaborator Author

Developers will still be able to open issues.

@paravoid
Copy link

As a drive-by contributor, and with respect to all of your work, I'd recommend against this. Not being able to open new issues is against the ethos and common practice of open source & community development, and feels a bit... alienating to me. Honestly, the already existing practice of resolving valid issues with "please open a discussion" has already felt a bit hostile to me and personally discouraged me from reporting bugs (or opening up "discussions").

It'd be helpful to understand the problem you are trying to solve. Is the consideration around the volume of bug reports, the backlog of it all, users being confused or something else? If the concern is about the volume of stale requests, have you considered something like e.g. https://docs.github.com/en/actions/managing-issues-and-pull-requests/closing-inactive-issues to just close inactive issues instead?

@Navid200
Copy link
Collaborator Author

@paravoid
The person who has to close the issues that should never have been opened has to spend time that can be spent elsewhere.
So, yes, the problem mainly is the volume.

Do you know that

  • on some Android 10 phones, if you rotate the phone to Landscape and then, return to portrait mode, the screen remains in Landscape!?
  • we have a database corruption issue?
  • how many redundant lines of code exists in xDrip because of WearOS?
  • the missed reading alert does not use volume profile, so you could just sleep through it?
  • there is no easy (safe) way to snooze an alert while driving if you don't have a companion watch?
  • the smart snooze and smart alert are not perfect; so, we get alerts when we shouldn't?
  • we also support a version of Nightsocut after Heroku ended their free service?

I know all of those and more because I have gone through all the issues and categorized them.
The number of open issues was approaching 1000. There are currently 133 open issues.
Having 1000 open issues will not allow contributors to see what the real problems are that needs their attention.
I don't want them to be closed just because they have been inactive. They are still problems that need to be resolved.
Can you help us with any of those?

We also have a lot of issues that have been addressed and resolved. So, things are working. This PR will streamline the process more.

We don't need a new issue stating "I started a sensor and after the 2-hour warm-up it is not working".
That's not an issue. That's really a question.
We spend a lot of time addressing those anyway.

A user experiencing problems, should start by opening a discussion. I go through all discussions. I either address them myself or ask someone with more expertise to address it.
If/when needed, some of these are turned into issues.
I am not saying there are no issues. That's not the purpose of this PR. I am saying GitHub is not set up to give 100% flexibility for the management of a free project.
This PR let's us change the behavior forced by GitHub that does not serve our needs.

Your opinion is important. It will be taken into consideration before this PR is rejected or approved.
This team is an awesome team. What is unique about the active members is that they do what needs to be done. We need more members. Do you want to help? Can you dedicate ongoing time to this project?

xDrip has a lot of users worldwide. But, it has only a few contributors. We need to make life manageable for those few serving the large community.

@Navid200
Copy link
Collaborator Author

Whether people open issues or discussions, I spend time on them. I am not complaining about that.
The time I spend here, I spend because I want to, not because I am doing anyone any favors.

We decided to ask everyone to use discussions as a starting point.
This decision was made quite a while ago. And it has not been revoked.

This PR addresses the issue that our mentioned decision is not executed perfectly by everyone.

I can add a few lines to thank people for coming to the repository to provide feedback.

@Navid200
Copy link
Collaborator Author

Navid200 commented Aug 8, 2023

This is what you will see, after this PR, clicking on new issue.
Screenshot 2023-08-08 124352

Another change is that currently, when you click on the button, you will be taken to discussions and you will need to click on new discussion to open one.
After this PR, clicking on the button is the same as clicking on new discussion. So, you can right away choose the category and start typing.

@Navid200 Navid200 requested a review from jamorham August 13, 2023 18:48
@Navid200 Navid200 mentioned this pull request Aug 25, 2023
@jamorham
Copy link
Collaborator

@Navid200 can you explain in words also what this PR does and how it works? thanks

@Navid200
Copy link
Collaborator Author

Navid200 commented Sep 24, 2023

If someone clicks on "New issue", they will be taken to a page with a note and a button on the right.

This is the note:
Thanks for taking the time to provide your input, which is very important. Please open a discussion (link on the right). A team member will respond, and if needed, create a corresponding issue. This may be unlike what you have experienced in other repositories. But, please have no doubt that we want to fix bugs and add more capabilities. Thanks for your help.

The button takes the user to the page that they can also go to by going to discussions and clicking on "New discussion".

Developers can bypass this (explained in a different channel) and open an issue directly.

@Navid200
Copy link
Collaborator Author

@jamorham Please merge this

@Navid200
Copy link
Collaborator Author

There is no need for this PR.
I can convert an issue that is a question to a discussion myself.

@Navid200 Navid200 closed this Jan 20, 2024
@Navid200 Navid200 deleted the Navid_2023_07_25b branch May 30, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants