-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No more accidental issues! #2966
Conversation
Users will still be able to create an issue from a discussion when instructed by a developer. |
Developers will still be able to open issues. |
As a drive-by contributor, and with respect to all of your work, I'd recommend against this. Not being able to open new issues is against the ethos and common practice of open source & community development, and feels a bit... alienating to me. Honestly, the already existing practice of resolving valid issues with "please open a discussion" has already felt a bit hostile to me and personally discouraged me from reporting bugs (or opening up "discussions"). It'd be helpful to understand the problem you are trying to solve. Is the consideration around the volume of bug reports, the backlog of it all, users being confused or something else? If the concern is about the volume of stale requests, have you considered something like e.g. https://docs.github.com/en/actions/managing-issues-and-pull-requests/closing-inactive-issues to just close inactive issues instead? |
@paravoid Do you know that
I know all of those and more because I have gone through all the issues and categorized them. We also have a lot of issues that have been addressed and resolved. So, things are working. This PR will streamline the process more. We don't need a new issue stating "I started a sensor and after the 2-hour warm-up it is not working". A user experiencing problems, should start by opening a discussion. I go through all discussions. I either address them myself or ask someone with more expertise to address it. Your opinion is important. It will be taken into consideration before this PR is rejected or approved. xDrip has a lot of users worldwide. But, it has only a few contributors. We need to make life manageable for those few serving the large community. |
Whether people open issues or discussions, I spend time on them. I am not complaining about that. We decided to ask everyone to use discussions as a starting point. This PR addresses the issue that our mentioned decision is not executed perfectly by everyone. I can add a few lines to thank people for coming to the repository to provide feedback. |
@Navid200 can you explain in words also what this PR does and how it works? thanks |
If someone clicks on "New issue", they will be taken to a page with a note and a button on the right. This is the note: The button takes the user to the page that they can also go to by going to discussions and clicking on "New discussion". Developers can bypass this (explained in a different channel) and open an issue directly. |
@jamorham Please merge this |
There is no need for this PR. |
Before:
Edit: This is not valid anymore. Please see the post after the next commit to see the latest.
After:
This PR removes the ability to open a new issue as you can see in the above images.
However, all the existing issues will still be there and visible to all.