Merge pull request #23 from 0xDEC0DE/issue/20

Make the Redis broker clean up aborted jobs
NicolasLM · May 2, 2022 · 7c8c0c6 · 7c8c0c6
2 parents 35d3928 + ace8026
commit 7c8c0c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/spinach/job.py b/spinach/job.py
@@ -189,7 +189,7 @@ def advance_job_status(namespace: str, job: Job, duration: float,
         return
 
     if isinstance(err, AbortException):
-        job.max_retries = 0
+        job.retries = job.max_retries
         logger.error(
             'Fatal error during execution of %s after %s, canceling retries',
             job, duration, exc_info=err

diff --git a/tests/test_job.py b/tests/test_job.py
@@ -118,10 +118,13 @@ def test_advance_job_status(job):
                        RetryException('Must retry', at=now))
     assert job.status is JobStatus.FAILED
 
+    # The job should have retried twice due to previous tests, ensure that
+    # an AbortException tops off the retry counter
     job.status = JobStatus.RUNNING
     job.max_retries = 10
+    assert job.retries == 2
     advance_job_status('namespace', job, 1.0, AbortException('kaboom'))
-    assert job.max_retries == 0
+    assert job.retries == 10
     assert job.status is JobStatus.FAILED