Refactor Yewdux state management #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds RepoFilter, which is much more flexible.
Prevents the extra request that was happening at the end of loading an organization. Was initially removed for simplicity, but re-added because we waste no cycles here :)
|
Thank you so much for the kind words about the stream, and for taking the time to contribute like this! I'm swamped with family things at the moment, but I'll try to come back to this in the next week or two and look this over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings! I recently stumbled onto this project from YouTube. Loved following your Yew/Rust journey!
There were a few questions about overall state management and structure towards the end. You decided to move away from shared state (which is a perfectly reasonable approach), however I'd like to propose an alternative. These changes demonstrate how you might continue to use Yewdux for all your state management needs.
I do not expect this to be merged. My primary goal was to provide a working solution, which will hopefully be a useful reference. By no means is it better or more "correct" than the current version, just another take on an interesting problem.
I recorded my thought process here, hopefully it's interesting and informative :)