Refactor NIFSTrait & port Mova impl to it #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiDimi
approved these changes
Oct 22, 2024
| _cs_prover_params: &CS::ProverParams, // not used in Mova since we don't commit to T | ||
| r1cs: &R1CS<C::ScalarField>, | ||
| transcript: &mut T, | ||
| pp_hash: C::ScalarField, |
There was a problem hiding this comment.
This is used for challenges that come from transcript/hashing, the pp_hash itself is a hash of several public values of the parameters (such as the circuit r1cs, the commitment schemes params, the poseidon config, etc) so that the challenges are dependent on the specific setup (and the same challenge is not generated between 2 different curves instantiations for example). In Nova & Mova papers I think that they appear denoted as pp (for 'public parameters').
| transcript.absorb(&mleT_evaluated); | ||
|
|
||
| let alpha_scalar = C::ScalarField::from_le_bytes_mod_order(b"alpha"); | ||
| transcript.absorb(&alpha_scalar); |
There was a problem hiding this comment.
We dont actually need the alpha_scalar. I removed it in my latest commit
| /// returns the folded committed instance | ||
| fn verify( | ||
| transcript: &mut T, | ||
| pp_hash: C::ScalarField, |
| transcript.absorb(&proof.mleT); | ||
|
|
||
| let alpha_scalar = C::ScalarField::from_le_bytes_mod_order(b"alpha"); | ||
| transcript.absorb(&alpha_scalar); |
* refactor NIFSTrait interface to fit Nova variants (Nova,Mova,Ova) Refactor NIFSTrait interface to fit Nova variants (Nova,Mova,Ova). The relevant change is instead of passing the challenge as input, now it passes the transcript and computes the challenges internally (Nova & Ova still compute a single challenge, but Mova computes multiple while absorbing at different steps). * port Mova impl to the NIFSTrait * remove unnecessary wrappers in the nova/zk.rs * remove Nova NIFS methods that are no longer needed after the refactor * put together the different NIFS implementations (Nova, Mova, Ova) so that they can interchanged at usage. The idea is that Nova and its variants (Ova & Mova) share most of the logic for the circuits & IVC & Deciders, so with the abstracted NIFS interface we will be able to reuse most of the already existing Nova code for having the Mova & Ova circuits, IVC, and Decider.
arnaucube
force-pushed
the
update-nifs-interface
branch
from
8e57b85
to
54e6b60
Compare
This was referenced Oct 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes in this PR are to code prior to the Mova implementation, just that the NIFS abstraction that we had before was abstracted for Nova & Ova but not for the Mova needs. With this PR the abstraction is more generic and future-proof, and it allows to interchange the NIFS of Nova, Mova, Ova without friction.
refactor NIFSTrait interface to fit Nova variants (Nova,Mova,Ova)
Refactor NIFSTrait interface to fit Nova variants (Nova,Mova,Ova). The relevant change is instead of passing the challenge as input, now it passes the transcript and computes the challenges internally (Nova & Ova still compute a single challenge, but Mova computes multiple while absorbing at different steps).
port Mova impl to the NIFSTrait
remove unnecessary wrappers in the nova/zk.rs
remove Nova NIFS methods that are no longer needed after the refactor
put together the different NIFS implementations (Nova, Mova, Ova) so that they can interchanged at usage.
The idea is that Nova and its variants (Ova & Mova) share most of the logic for the circuits & IVC & Deciders, so with the abstracted NIFS interface we will be able to reuse most of the already existing Nova code for having the Mova & Ova circuits, IVC, and Decider.
Doing this PR here so that it can be merged into the branch
NiDimi:introducing_mova, and then it updates the PR privacy-scaling-explorations#161