-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Empty Array Annotations in NixIO #806
Support Empty Array Annotations in NixIO #806
Conversation
There shouldn't be any issue using the property.type since we don't use it anywhere else in the Neo NIXIO. Not sure exactly what bug this is triggering. It seems there's an issue with the |
Didn't get the change to look at this closely during the last few days but I narrowed down the issue: Should be able to fix it in the next day or so and get back to you. |
G-Node/nixpy#462 fixes the issue (tested locally with your branch). Should be merged soon and I'll schedule a release. |
@achilleas-k Any news here? Are you planning another beta release soon? |
Sorry for not getting back to you sooner, I was off last week. I'm working on something now that should be the last bit before we can move forward with 1.5 proper. I'll probably release another beta when it's ready before finalising everything. I'm hoping I can get it out sometime next week. |
@achilleas-k Any news on the nixpy side? Let's us know when you are ready ;) |
Thanks for the nudge, Julia. The latest beta should work. I had forgotten about this issue. |
The failing tests are not related to the NixIO and are fixed in master already. |
Currently, the
property.definition
attribute is used to tag both empty annotations and array annotations. This breaks down in the case of empty array annotations.I moved the array annotation tag to
property.type
which appeared to be unused as well, and I added a test with an empty array annotation.@achilleas-k is using the
property.type
attribute feasible / does that cause any other issues down the line? It only seems to work withnixio<=1.5.0b3
.