Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nbd-server infinite loop for TLS #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix nbd-server infinite loop for TLS #173

wants to merge 1 commit into from

Commits on Oct 1, 2024

  1. Fix nbd-server infinite loop for TLS 

    When the nbd-client disconnects from a TLS connection, the gnutls_record_recv
function will return a zero value. Due to a faulty/missing check, this
causes the readit_tls call to enter an infinite loop, with all terrible
consequences that this has. This is a very problematic bug that causes a
full CPU usage, and is only treatable by killing the nbd-server.

This fix adds the missing check and an appropriate message that
terminates the forked server child graceously.

Signed-off-by: Janis Kalofolias <[email protected]>
    @kalofoli
    kalofoli authored and Janis Kalofolias committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4a447f4 View commit details
    Browse the repository at this point in the history