Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default gas limit from 30M to 36M #7879

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Increase default gas limit from 30M to 36M #7879

merged 2 commits into from
Dec 10, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Dec 9, 2024

Changes

  • 36M is the current safe limit for all participants pre-Pectra (EIP-7623) and taking into account an active propagation size limit bug in CL clients.

See also: https://ethresear.ch/t/on-increasing-the-block-gas-limit-technical-considerations-path-forward/21225

Also being done by Erigon: erigontech/erigon#13057

Types of changes

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • No

@kamilchodola
Copy link
Contributor

I'm all for approval!

Waiting for others tho as I know right after hitting approve you have automerge script :D

@kamilchodola
Copy link
Contributor

kamilchodola commented Dec 9, 2024

@benaadams few more tests to be adjusted like:
Test_StoreBeaconRoot_AccessListNotNull
Is_calculating_correct_gasLimit

Also I see usage hardcoded in:
BeaconBlockRootHandler
ExecutionRequestsProcessor
SystemTransaction
WithdrawalContract

Can search by a 30_000_000 phrase in entire solution

@benaadams
Copy link
Member Author

Test_StoreBeaconRoot_AccessListNotNull

Why is it not failing? 🤔

@benaadams
Copy link
Member Author

Can search by a 30_000_000 phrase in entire solution

Ah, got yah

Copy link
Contributor

@smartprogrammer93 smartprogrammer93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@benaadams
Copy link
Member Author

@benaadams few more tests to be adjusted like:

...

Can search by a 30_000_000 phrase in entire solution

I don't think they should change as the block limit will still be 30M so we shouldn't bake in a higher value (though perhaps they should be reading from block header instead)

@LukaszRozmej
Copy link
Member

System calls should stay 30mln

@benaadams benaadams merged commit 3059331 into master Dec 10, 2024
79 checks passed
@benaadams benaadams deleted the lets-gooooo branch December 10, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants