-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase default gas limit from 30M to 36M #7879
Conversation
I'm all for approval! Waiting for others tho as I know right after hitting approve you have automerge script :D |
@benaadams few more tests to be adjusted like: Also I see usage hardcoded in: Can search by a 30_000_000 phrase in entire solution |
Why is it not failing? 🤔 |
Ah, got yah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG
I don't think they should change as the block limit will still be 30M so we shouldn't bake in a higher value (though perhaps they should be reading from block header instead) |
System calls should stay 30mln |
Changes
See also: https://ethresear.ch/t/on-increasing-the-block-gas-limit-technical-considerations-path-forward/21225
Also being done by Erigon: erigontech/erigon#13057
Types of changes
What types of changes does your code introduce?
Testing
Requires testing