-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParallelUnbalancedWork for efficient unbalanced parallel loops #7787
Open
benaadams
wants to merge
14
commits into
master
Choose a base branch
from
parallel-unbalanced-work
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+546
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide some kind of benchmark?
src/Nethermind/Nethermind.Consensus/Processing/BlockCachePreWarmer.cs
Outdated
Show resolved
Hide resolved
- Introduced the `ParallelUnbalancedWork` class to efficiently execute parallel loops over a range of integers, handling unbalanced workloads. - Added static `For` methods to support parallel execution with and without thread-local data, including initialization and finalization functions. - Utilized thread pooling and a shared counter (`SharedCounter`) to distribute iterations among threads dynamically. - Implemented internal classes (`BaseData`, `Data`, and `InitProcessor<TLocal>`) to manage shared state and thread synchronization. - Aimed to optimize performance in scenarios where the workload per iteration is uneven, ensuring better resource utilization and reduced execution time.
benaadams
force-pushed
the
parallel-unbalanced-work
branch
from
November 28, 2024 16:52
0072faa
to
061956a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ParallelUnbalancedWork
class to efficiently execute parallel loops, handling unbalanced workloads.SharedCounter
to distribute iterations among threads dynamically..Wait
ing for background threads to completeParallel.For
Types of changes
What types of changes does your code introduce?
Testing
Requires testing