Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recreation of light blob tx collection #7584

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix recreation of light blob tx collection #7584

merged 3 commits into from
Oct 10, 2024

Conversation

marcindsobczak
Copy link
Contributor

Changes

  • Fix recreation of light blob tx collection

Fixes regression from #7572 and #7581

it was failing, because we are loading LightTransactions from db and trying to add to in-memory collection using TryInsert, which in SortedPool is calling IncertCore, which is overriden in PersistentBlobTxDistinctSortedPool. We should use directly InsertCore to skip the override which is adding txs to db

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@kamilchodola
Copy link
Contributor

My node works again so can assume it is fixing the issue

@marcindsobczak marcindsobczak merged commit 71335db into master Oct 10, 2024
73 of 74 checks passed
@marcindsobczak marcindsobczak deleted the fix/blobs branch October 10, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants