Fix recreation of light blob tx collection #7584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes regression from #7572 and #7581
it was failing, because we are loading
LightTransactions
from db and trying to add to in-memory collection usingTryInsert
, which inSortedPool
is callingIncertCore
, which is overriden inPersistentBlobTxDistinctSortedPool
. We should use directlyInsertCore
to skip the override which is adding txs to dbTypes of changes
What types of changes does your code introduce?
Testing
Requires testing