Move dispose after await.

NethermindEth · Dec 9, 2024 · 589baec · 589baec
1 parent a10180b
commit 589baec
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Nethermind/Nethermind.Synchronization/StateSync/StateSyncDownloader.cs b/src/Nethermind/Nethermind.Synchronization/StateSync/StateSyncDownloader.cs
@@ -39,6 +39,7 @@ public async Task Dispatch(PeerInfo peerInfo, StateSyncBatch batch, Cancellation
             ISyncPeer peer = peerInfo.SyncPeer;
             Task<IOwnedReadOnlyList<byte[]>> task = null;
             HashList? hashList = null;
+            GetTrieNodesRequest? getTrieNodesRequest = null;
             // Use GETNODEDATA if possible. Firstly via dedicated NODEDATA protocol
             if (peer.TryGetSatelliteProtocol(Protocol.NodeData, out INodeDataPeer nodeDataHandler))
             {
@@ -65,8 +66,8 @@ public async Task Dispatch(PeerInfo peerInfo, StateSyncBatch batch, Cancellation
                 else
                 {
                     if (Logger.IsTrace) Logger.Trace($"Requested TrieNodes via SnapProtocol from peer {peer}");
-                    using GetTrieNodesRequest request = GetGroupedRequest(batch);
-                    task = snapHandler.GetTrieNodes(request, cancellationToken);
+                    getTrieNodesRequest = GetGroupedRequest(batch);
+                    task = snapHandler.GetTrieNodes(getTrieNodesRequest, cancellationToken);
                 }
             }
 
@@ -80,6 +81,7 @@ public async Task Dispatch(PeerInfo peerInfo, StateSyncBatch batch, Cancellation
                 batch.Responses = await task;
 
                 if (hashList is not null) HashList.Return(hashList);
+                getTrieNodesRequest?.Dispose();
             }
             catch (Exception e)
             {