This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Upgrade Conductor to Spring3 #3855
Open
LuisLainez
wants to merge
18
commits into
Netflix:main
Choose a base branch
from
LuisLainez:issue/upgradeConductorToSpring3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade Conductor to Spring3 #3855
LuisLainez
wants to merge
18
commits into
Netflix:main
from
LuisLainez:issue/upgradeConductorToSpring3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisLainez
commented
Nov 21, 2023
Validation.byProvider(ApacheValidationProvider.class) | ||
.configure() | ||
.buildValidatorFactory(); | ||
validatorFactory = Validation.buildDefaultValidatorFactory(); | ||
validator = validatorFactory.getValidator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to delete the ApacheValidator because bval-jsr does not allow the new jakarta stuff - and version 3x is not yet public.
LuisLainez
commented
Nov 21, 2023
Validation.byProvider(ApacheValidationProvider.class) | ||
.configure() | ||
.buildValidatorFactory(); | ||
validatorFactory = Validation.buildDefaultValidatorFactory(); | ||
validator = validatorFactory.getValidator(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to delete the ApacheValidator because bval-jsr does not allow the new jakarta stuff - and version 3x is not yet public.
LuisLainez
changed the title
Issue/upgrade conductor to spring3
Upgrade Conductor to Spring3
Nov 21, 2023
Merge dependency management tweaks
…ssue/upgradeConductorToSpring3
This was referenced Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Bugfix
Feature
Refactoring (no functional changes, no api changes)
[X ] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)
WHOSUSING.md
Other (please describe):
NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.
### Changes in this PR
Upgrading Conductor to Spring 3
The main changes are:
Next steps - not required for this release :