Update handling for parameterized methods via ConfigProxyFactory #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, let's wait for those users' feedback. |
|
I've received confirmation from the users that this change will not affect them (the properties were either unused, or in decommissioned applications) |
|
👍 Let's merge, then. But also, since there's a visible behavior change, let's remember to bump the next release's minor version to 2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even if a top level prefix is specified in an @configuration annotation, parameterized methods in the body will ignore the prefix.
This change updates this behavior to properly acknowledge the prefix annotation.
This is notably breaking, so we keep backward compatibility for users who compensated by having their parameterized methods include the prefix. However, we will be breaking users that did not include the prefix.
Putting this up for review now, but still following up with a few clients to ensure the safety of this change.