Fix ClassCastException in FindFields

Netflix-Skunkworks · Aug 28, 2016 · 444ec02 · 444ec02
1 parent 53791d3
commit 444ec02
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 4 deletions.
diff --git a/src/main/kotlin/com/netflix/java/refactor/AbstractRefactorTest.kt b/src/main/kotlin/com/netflix/java/refactor/AbstractRefactorTest.kt
@@ -36,6 +36,6 @@ fun fullyQualifiedName(sourceStr: String): String? {
     val pkgMatcher = Pattern.compile("\\s*package\\s+([\\w\\.]+)").matcher(sourceStr)
     val pkg = if (pkgMatcher.find()) pkgMatcher.group(1) + "." else ""
 
-    val classMatcher = Pattern.compile("\\s*(class|interface|enum)\\s+(\\w+)").matcher(sourceStr)
+    val classMatcher = Pattern.compile("\\s*(class|interface|enum)\\s*(<[^>]*>?)\\s+(\\w+)").matcher(sourceStr)
     return if (classMatcher.find()) pkg + classMatcher.group(2) else null
 }
diff --git a/src/main/kotlin/com/netflix/java/refactor/find/FindFields.kt b/src/main/kotlin/com/netflix/java/refactor/find/FindFields.kt
@@ -18,10 +18,13 @@ class FindFields(val clazz: String, val includeInherited: Boolean) : AstScannerB
 class FindFieldScanner(val op: FindFields) : SingleCompilationUnitAstScanner<List<Field>>() {
     override fun visitCompilationUnit(node: CompilationUnitTree?, p: Context?): List<Field> {
         super.visitCompilationUnit(node, p)
-        return cu.defs.filterIsInstance<JCTree.JCClassDecl>().flatMap { superFields(it.type as Type.ClassType) }
+        return cu.defs.filterIsInstance<JCTree.JCClassDecl>().flatMap { superFields(it.type as Type.ClassType?) }
     }
 
-    private fun superFields(type: Type.ClassType, inHierarchy: Boolean = false): List<Field> {
+    private fun superFields(type: Type.ClassType?, inHierarchy: Boolean = false): List<Field> {
+        if(type == null)
+            return emptyList()
+
         if (type.supertype_field == Type.noType)
             return emptyList()
 

diff --git a/...tflix/java/refactor/find/FindFieldTest.kt → ...flix/java/refactor/find/FindFieldsTest.kt b/...tflix/java/refactor/find/FindFieldTest.kt → ...flix/java/refactor/find/FindFieldsTest.kt
@@ -5,7 +5,7 @@ import org.junit.Assert.assertEquals
 import org.junit.Test
 import kotlin.test.assertTrue
 
-class FindFieldTest: AbstractRefactorTest() {
+class FindFieldsTest : AbstractRefactorTest() {
 
     @Test
     fun findField() {
@@ -50,4 +50,18 @@ class FindFieldTest: AbstractRefactorTest() {
         assertEquals("list", parseJava(b, a).findFieldsIncludingInherited(List::class.java).firstOrNull()?.name)
         assertTrue(parseJava(b, a).findFieldsIncludingInherited(Set::class.java).isEmpty())
     }
+
+    // FIXME this is intended to test the case where there is something that satisfies cu.defs.find { it.type == null }, but
+    // doesn't currently
+    @Test
+    fun unresolvableTypeSymbol() {
+        val b = java("""
+            import java.util.List;
+            public class <T extends A> B<T> {
+                List unresolvable;
+            }
+		""")
+
+        parseJava(b).findFields(List::class.java)
+    }
 }