Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserialize MultiPolygon Array of Empty Coordinates Array #140

Merged
merged 3 commits into from
May 1, 2024
Merged

Deserialize MultiPolygon Array of Empty Coordinates Array #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e501cc8
Deserialize MultiPolygon Array of Empty Coordinates Array
dickinsonm Mar 25, 2024
9af1dac
Merge branch 'NetTopologySuite:develop' into deserialize-multipolygon…
dickinsonm Apr 16, 2024
1b4d263
Change to MultiPolygon with empty Polygon
dickinsonm Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/NetTopologySuite.IO.GeoJSON4STJ/Converters/StjParsedCoordinates.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ public static StjParsedCoordinates Parse(ref Utf8JsonReader reader, GeometryFact
reader.AssertToken(JsonTokenType.StartArray);
reader.ReadOrThrow();

if (reader.TokenType == JsonTokenType.EndArray)
{
reader.ReadOrThrow();
if (reader.TokenType == JsonTokenType.EndArray)
{
return new StjParsedCoordinates(factory.CreateMultiPolygon(new Polygon[] { factory.CreatePolygon() }));
}
}

if (reader.TokenType == JsonTokenType.Number)
{
return new StjParsedCoordinates(ParseCoordinateSequence(ref reader, factory));
Expand Down
12 changes: 12 additions & 0 deletions test/NetTopologySuite.IO.GeoJSON4STJ.Test/Converters/GeometryConverterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ public void TestReadWithEmptyCoordinatesArray(string type)
Assert.That(geom.IsEmpty);
}

[TestCase]
public void TestMultiPolygonReadWithArrayOfEmptyCoordinatesArray()
{
string geoJson = @"{ ""type"" : ""MultiPolygon"", ""coordinates"": [ [] ] }";
var options = DefaultOptions;
var geom = Deserialize(geoJson, options);

Assert.That(geom != null);
Assert.That(new MultiPolygon(new Polygon[] { new Polygon(null) }) == geom);
Assert.That(geom.IsEmpty);
}

[GeoJsonIssueNumber(57)]
[TestCase("{\"type\": \"Point\", \"coordinates\": [], \"bbox\": null}")]
[TestCase("{\"type\": \"LineString\", \"coordinates\": [], \"bbox\": null}")]
Expand Down
Loading