-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Add SVM QoS Policy Activation #346
base: integration/main
Are you sure you want to change the base?
Conversation
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
ae7e93e
to
8c5e7f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do you expect users to ever pass in the UUID vs name?
When we wrote the Ansible/Terraform modules/resource, we've already assume users would always use name, and we would treat UUID as more of a internal thing. As a user is having both name and UUID useful?
Optional: true, | ||
Computed: true, | ||
}, | ||
"id": schema.StringAttribute{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to use name all the time, as UUID is not something user friendly, and name itself can handle all functionality, so we have used name in all our Ansible/Terrafrom modules/resources. Unless you have an explicit case, let us know
Adds ability to configure
qos_policy
parameter of SVMs.Needs to be a dedicated resource, as creating a QoS Policy scoped to an SVM, and then activating it for the SVM, is a 2-step process. See documentation for details.
Closes #301.
Acceptance tests WIP:
$ TF_ACC=1 go test ./internal/provider/svm/svm_qos_policy_activation_resource_test.go -v === RUN TestAccSvmQosPolicyActivationResource --- PASS: TestAccSvmQosPolicyActivationResource (2.96s) PASS ok command-line-arguments 2.967s
Example Terraform Configuration WIP: