-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Add interface location.broadcast_domain
parameter
#337
base: integration/main
Are you sure you want to change the base?
[Enhancement]: Add interface location.broadcast_domain
parameter
#337
Conversation
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
…ocation Signed-off-by: Achim Christ <[email protected]>
…nged Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
location.broadcast_domain
parameterlocation.broadcast_domain
parameter
location.broadcast_domain
parameterlocation.broadcast_domain
parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as well just missing the documentation updates.
stringplanmodifier.RequiresReplace(), | ||
}, | ||
}, | ||
"id": schema.StringAttribute{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically don't have UUID in resources other than the top level one. As we only expect users to know the names and not the internal ID.
We do the top level one as computed as we do need a unique value for terraform.
So this ID can probably be removed for the Resouce. (For the data source it can stay)
Adds ability to configure
location.broadcast_domain
parameter of IP Interfaces.Closes #305.
Acceptance tests pass:
$ TF_ACC=1 go test ./internal/provider/networking/network_ip_interface_resource_test.go -v === RUN TestAccNetworkIpInterfaceResource --- PASS: TestAccNetworkIpInterfaceResource (10.65s) PASS ok command-line-arguments 10.664s
$ TF_ACC=1 go test ./internal/provider/networking/network_ip_interface_resource_alias_test.go -v === RUN TestAccNetworkIpInterfaceResourceAlias --- PASS: TestAccNetworkIpInterfaceResourceAlias (9.21s) PASS ok command-line-arguments 9.225s
Example Terraform Configurations: