Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: Broadcast Domain #333

Open
wants to merge 14 commits into
base: integration/main
Choose a base branch
from

Conversation

acch
Copy link

@acch acch commented Nov 4, 2024

Adds ability to create broadcast domains.

Closes #303.

Acceptance tests pass:

$ TF_ACC=1 go test ./internal/provider/networking/network_broadcast_domain_resource_test.go -v
=== RUN   TestAccNetworkBroadcastDomainResource
--- PASS: TestAccNetworkBroadcastDomainResource (3.73s)
PASS
ok      command-line-arguments  3.733s

Example Terraform Configuration:

// sample broadcast domain with required properties
resource "netapp-ontap_network_broadcast_domain" "example" {
  cx_profile_name = ...
  ipspace         = "Default"
  name            = "bd1"
  mtu             = "1500"
}

@acch acch force-pushed the 303-broadcast-domain-resource branch 2 times, most recently from fc42650 to e4bdb07 Compare November 7, 2024 14:28
@acch acch marked this pull request as ready for review November 7, 2024 14:44
@suhasbshekar suhasbshekar added this to the 2.1 milestone Nov 7, 2024
@suhasbshekar suhasbshekar added the New Resource New Request for an ONTAP Resource label Nov 7, 2024
@acch acch force-pushed the 303-broadcast-domain-resource branch 2 times, most recently from aaa3580 to ed9045b Compare November 20, 2024 09:39
@carchi8py carchi8py added the New Data Source New Request for an ONTAP Data source label Jan 6, 2025
Copy link
Contributor

@carchi8py carchi8py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only thing missing is the documentation pages.

@acch acch force-pushed the 303-broadcast-domain-resource branch from ed9045b to 46a712c Compare January 8, 2025 14:18
@acch acch force-pushed the 303-broadcast-domain-resource branch from 46a712c to 96789d4 Compare January 8, 2025 14:19
@acch
Copy link
Author

acch commented Jan 8, 2025

Thanks @carchi8py for your feedback!

I've manually added the documentation pages in the docs/ directory. This is very tedious; isn't it possible to generate the docs automatically? The TF scaffolding template contains scripts for that (here), but I see that you've removed them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Data Source New Request for an ONTAP Data source New Resource New Request for an ONTAP Resource
Projects
Status: 2.1
Development

Successfully merging this pull request may close these issues.

[New Resource]: Broadcast Domain
3 participants