-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource]: Broadcast Domain #333
base: integration/main
Are you sure you want to change the base?
Conversation
fc42650
to
e4bdb07
Compare
aaa3580
to
ed9045b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only thing missing is the documentation pages.
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
ed9045b
to
46a712c
Compare
Signed-off-by: Achim Christ <[email protected]>
46a712c
to
96789d4
Compare
Thanks @carchi8py for your feedback! I've manually added the documentation pages in the |
Adds ability to create broadcast domains.
Closes #303.
Acceptance tests pass:
$ TF_ACC=1 go test ./internal/provider/networking/network_broadcast_domain_resource_test.go -v === RUN TestAccNetworkBroadcastDomainResource --- PASS: TestAccNetworkBroadcastDomainResource (3.73s) PASS ok command-line-arguments 3.733s
Example Terraform Configuration: