Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource]: Broadcast Domain #333

Open
wants to merge 13 commits into
base: integration/main
Choose a base branch
from
Open

[New Resource]: Broadcast Domain #333

wants to merge 13 commits into from

Conversation

acch
Copy link

@acch acch commented Nov 4, 2024 •
edited
Loading

Adds ability to create broadcast domains.

Closes #303.

Acceptance tests pass:

$ TF_ACC=1 go test ./internal/provider/networking/network_broadcast_domain_resource_test.go -v
=== RUN   TestAccNetworkBroadcastDomainResource
--- PASS: TestAccNetworkBroadcastDomainResource (3.73s)
PASS
ok      command-line-arguments  3.733s

Example Terraform Configuration:

// sample broadcast domain with required properties
resource "netapp-ontap_network_broadcast_domain" "example" {
  cx_profile_name = ...
  ipspace         = "Default"
  name            = "bd1"
  mtu             = "1500"
}

@acch acch force-pushed the 303-broadcast-domain-resource branch from d88504f to 23ad75f Compare November 5, 2024 18:46
@acch acch force-pushed the 303-broadcast-domain-resource branch from fc42650 to e4bdb07 Compare November 7, 2024 14:28
@acch acch marked this pull request as ready for review November 7, 2024 14:44
@acch acch mentioned this pull request Nov 7, 2024
Open
@suhasbshekar suhasbshekar added this to the 2.1 milestone Nov 7, 2024
@suhasbshekar suhasbshekar added the New Resource New Request for an ONTAP Resource label Nov 7, 2024
@acch acch force-pushed the 303-broadcast-domain-resource branch from c5db28a to 09abe50 Compare November 18, 2024 15:24
@acch acch force-pushed the 303-broadcast-domain-resource branch from aaa3580 to ed9045b Compare November 20, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carchi8py carchi8py Awaiting requested review from carchi8py carchi8py is a code owner

@chuyich chuyich Awaiting requested review from chuyich chuyich is a code owner

@suhasbshekar suhasbshekar Awaiting requested review from suhasbshekar suhasbshekar is a code owner

@wenjun666 wenjun666 Awaiting requested review from wenjun666 wenjun666 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
New Resource New Request for an ONTAP Resource
Projects
Terraform for ONTAP Roadmap
Status: 2.1
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

[New Resource]: Broadcast Domain
2 participants
@acch @suhasbshekar