Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add SVM QoS Policy Activation #346

Open
wants to merge 5 commits into
base: integration/main
Choose a base branch
from
Open

[Enhancement]: Add SVM QoS Policy Activation #346

wants to merge 5 commits into from

Conversation

acch
Copy link

@acch acch commented Dec 3, 2024 •
edited
Loading

Adds ability to configure qos_policy parameter of SVMs.

Needs to be a dedicated resource, as creating a QoS Policy scoped to an SVM, and then activating it for the SVM, is a 2-step process. See documentation for details.

Closes #301.

Acceptance tests WIP:

$ TF_ACC=1 go test ./internal/provider/svm/svm_qos_policy_activation_resource_test.go -v
=== RUN   TestAccSvmQosPolicyActivationResource
--- PASS: TestAccSvmQosPolicyActivationResource (2.96s)
PASS
ok      command-line-arguments  2.967s

Example Terraform Configuration WIP:

resource "netapp-ontap_svm_qos_policy_activation" "example" { 
  svm = {
    name = "svm01"
  }
  qos_policy = {
    name = "performance_svm01"
  }
}

@acch acch force-pushed the 301-svm-qos-policy-activation branch from ae7e93e to 8c5e7f1 Compare December 9, 2024 13:35
@acch acch marked this pull request as ready for review December 9, 2024 13:42
@acch acch mentioned this pull request Dec 9, 2024
Open
@acch acch changed the title Add SVM QoS Policy Activation [Enhancement]: Add SVM QoS Policy Activation Dec 9, 2024
@carchi8py carchi8py added the enhancement New feature or request label Dec 9, 2024
@carchi8py carchi8py added this to the 2.1 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carchi8py carchi8py Awaiting requested review from carchi8py carchi8py is a code owner

@chuyich chuyich Awaiting requested review from chuyich chuyich is a code owner

@suhasbshekar suhasbshekar Awaiting requested review from suhasbshekar suhasbshekar is a code owner

@wenjun666 wenjun666 Awaiting requested review from wenjun666 wenjun666 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Terraform for ONTAP Roadmap
Status: 2.1
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

[New Resource]: SVM QoS Policy Activation
2 participants
@acch @carchi8py