perf: improve memory and cpu performance of rest collector #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the gjson `String()` method will often cause the entire JSON string to be retained in memory. This PR copies gjson to the thirdparty package and adds a `ClonedString` method to `gjson.Result`. The `ClonedString` method returns a cloned copy of the Result string so that the larger JSON string is available for garbage collection. The Rest and RestPerf collectors were updated to use `gjson.ClonedString()`. A similar fix was made in #2054 for RestPerf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the gjson
String()method will often cause the entire JSON string to be retained in memory.This PR copies gjson to the thirdparty package and adds a
ClonedStringmethod togjson.Result. TheClonedStringmethod returns a cloned copy of the Result string so that the larger JSON string is available for garbage collection.The Rest and RestPerf collectors were updated to use
gjson.ClonedString().A similar fix was made in #2054 for RestPerf.