Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tracking cluster image update progress via Rest #3306

Merged
merged 15 commits into from
Nov 25, 2024
Merged

feat: Tracking cluster image update progress via Rest #3306

merged 15 commits into from
Nov 25, 2024

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Nov 19, 2024 

cluster_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",phase="validation",phase_name="Pre-update checks",status="completed"} 1.0
cluster_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",phase="ontap_updates",phase_name="ONTAP updates",status="completed"} 1.0
cluster_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",phase="post_update_checks",phase_name="Post-update checks",status="completed"} 1.0

@cla-bot cla-bot bot added the cla-signed label Nov 19, 2024
@Hardikl Hardikl linked an issue Nov 19, 2024 that may be closed by this pull request
Track ONTAP image update progress for a cluster #3218
Closed
cgrinds
cgrinds previously approved these changes Nov 19, 2024
View reviewed changes
@Hardikl
Copy link
Contributor Author

Hardikl commented Nov 21, 2024 

harvest % curl -s http://localhost:13001/metrics  | grep cl
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="Cluster/management switch support"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="Manual checks"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="NFS mounts"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="ONTAP API deprecation check"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="SAN compatibility"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="SnapMirror Synchronous status"} 1

cluster_software_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-01",phase="ONTAP updates",state="completed"} 1
cluster_software_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-02",phase="ONTAP updates",state="completed"} 1
cluster_software_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-01",phase="Post-update checks",state="completed"} 1

cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-download-job",node="umeng-aff300-01",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-failover-job",node="umeng-aff300-01",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-giveback-job",node="umeng-aff300-01",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-download-job",node="umeng-aff300-02",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-failover-job",node="umeng-aff300-02",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-giveback-job",node="umeng-aff300-02",state="completed"} 1

@rahulguptajss
Copy link
Contributor 

harvest % curl -s http://localhost:13001/metrics  | grep cl
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="Cluster/management switch support"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="Manual checks"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="NFS mounts"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="ONTAP API deprecation check"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="SAN compatibility"} 1
cluster_software_validation_labels{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="SnapMirror Synchronous status"} 1

cluster_software_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-01",phase="ONTAP updates",state="completed"} 1
cluster_software_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-02",phase="ONTAP updates",state="completed"} 1
cluster_software_update_labels{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-01",phase="Post-update checks",state="completed"} 1

cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-download-job",node="umeng-aff300-01",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-failover-job",node="umeng-aff300-01",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-giveback-job",node="umeng-aff300-01",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-download-job",node="umeng-aff300-02",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-failover-job",node="umeng-aff300-02",state="completed"} 1
cluster_software_status_labels{cluster="umeng-aff300-01-02",datacenter="rest",name="do-giveback-job",node="umeng-aff300-02",state="completed"} 1

No need to append _labels to metric names.

@Hardikl
Copy link
Contributor Author

Hardikl commented Nov 21, 2024 

harvest % curl -s http://localhost:13001/metrics  | grep cl
# HELP cluster_software_update Metric for cluster_software
# TYPE cluster_software_update gauge
cluster_software_update{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-01",phase="ONTAP updates",state="completed"} 1
cluster_software_update{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-02",phase="ONTAP updates",state="completed"} 1
cluster_software_update{cluster="umeng-aff300-01-02",datacenter="rest",node="umeng-aff300-01",phase="Post-update checks",state="completed"} 1
# HELP cluster_software_status Metric for cluster_software
# TYPE cluster_software_status gauge
cluster_software_status{cluster="umeng-aff300-01-02",datacenter="rest",name="do-giveback-job",node="umeng-aff300-01",state="completed"} 1
cluster_software_status{cluster="umeng-aff300-01-02",datacenter="rest",name="do-download-job",node="umeng-aff300-02",state="completed"} 1
cluster_software_status{cluster="umeng-aff300-01-02",datacenter="rest",name="do-failover-job",node="umeng-aff300-02",state="completed"} 1
cluster_software_status{cluster="umeng-aff300-01-02",datacenter="rest",name="do-giveback-job",node="umeng-aff300-02",state="completed"} 1
cluster_software_status{cluster="umeng-aff300-01-02",datacenter="rest",name="do-download-job",node="umeng-aff300-01",state="completed"} 1
cluster_software_status{cluster="umeng-aff300-01-02",datacenter="rest",name="do-failover-job",node="umeng-aff300-01",state="completed"} 1
# HELP cluster_software_validation Metric for cluster_software
# TYPE cluster_software_validation gauge
cluster_software_validation{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="SnapMirror Synchronous status"} 1
cluster_software_validation{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="Cluster/management switch support"} 1
cluster_software_validation{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="Manual checks"} 1
cluster_software_validation{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="NFS mounts"} 1
cluster_software_validation{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="ONTAP API deprecation check"} 1
cluster_software_validation{cluster="umeng-aff300-01-02",datacenter="rest",status="warning",update_check="SAN compatibility"} 1

@Hardikl
Copy link
Contributor Author

Hardikl commented Nov 21, 2024

I would be planning to add one new panel Cluster Software having 3 tables which has these new 3 metrics.

@Hardikl
Copy link
Contributor Author

Hardikl commented Nov 22, 2024

image

@Hardikl
Copy link
Contributor Author

Hardikl commented Nov 22, 2024

image image

image

image

@Hardikl
Copy link
Contributor Author

Hardikl commented Nov 25, 2024

image

rahulguptajss
rahulguptajss reviewed Nov 25, 2024
View reviewed changes
cmd/tools/generate/counter.yaml Outdated Show resolved Hide resolved
cmd/tools/generate/counter.yaml Outdated Show resolved Hide resolved
cmd/tools/generate/counter.yaml Outdated Show resolved Hide resolved
cmd/tools/generate/counter.yaml Outdated Show resolved Hide resolved
cmd/tools/generate/counter.yaml Outdated Show resolved Hide resolved
@cgrinds cgrinds merged commit 21f9262 into main Nov 25, 2024
7 checks passed
@cgrinds cgrinds deleted the hl_cl_upg branch November 25, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulguptajss rahulguptajss rahulguptajss left review comments

@cgrinds cgrinds cgrinds approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track ONTAP image update progress for a cluster
3 participants
@Hardikl @rahulguptajss @cgrinds