perf: reduce allocs when rendering metrics #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reduces allocations by an order of magnitude through two optimizations: 1. Avoiding slice reallocations 2. Rendering metrics into a shared buffer ## Scenario - Poll sar with single RestPerf volume collector - Changed collector.go to export each matrix 240 times - Take heap dump and report on `alloc_space` bytes for `Prometheus.render` ## Results Before change: 1.41 GB is alloced from `render` After change: 124.64 MB is alloced from `render` Thanks to ChrisGautcher for reporting
rahulguptajss
approved these changes
Oct 17, 2024
Hardikl
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces allocations by an order of magnitude through two optimizations:
Scenario
alloc_spacebytes forPrometheus.renderResults
Before change:
1.41 GB is alloced from
renderAfter change:
124.64 MB is alloced from
renderThanks to ChrisGautcher for reporting