Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change auth credential script logging to debug #3191

Merged
merged 1 commit into from
Oct 3, 2024
Merged

refactor: change auth credential script logging to debug #3191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/auth/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ func (c *Credentials) execScript(cmdPath string, kind string, timeout string, e
response := ScriptResponse{}
lookPath, err := exec.LookPath(cmdPath)
if err != nil {
return response, fmt.Errorf("script lookup failed kind=%s err=%w", kind, err)
c.logger.Debug("Failed to find script", slog.Any("err", err), slog.String("script", cmdPath), slog.String("kind", kind))
// Don't return the error, err, since it may contain credentials
return response, fmt.Errorf("script lookup failed kind=%s", kind)
}
if timeout == "" {
timeout = defaultTimeout
Expand Down