feat: handle url limit in rest #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrinds
reviewed
Oct 3, 2024
| b.fields = []string{"*"} | ||
| } | ||
|
|
||
| if len(b.hiddenFields) > 0 { |
There was a problem hiding this comment.
If hidden fields are added below the URLMaxLimit check, they may cause the URL to exceed the max. Hidden fields need to be part of the max check
There was a problem hiding this comment.
I was thinking that, if hiddenFields would be prior then if it exceed the limit, then it will pass * and no hidden fields would be coming in that response.
But yeah, if it was in later then url rest limit 414 error will come and whole rest call would be failed.
rahulguptajss
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would be in
build()function which would be called by rest cli and rest/ems collector calls.