Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not log stdout when a credential script fails #3163

Merged
merged 1 commit into from
Sep 20, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pkg/auth/auth.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,6 @@ func (c *Credentials) execScript(cmdPath string, kind string, timeout string, e
c.logger.Error().Err(err).
Str("script", lookPath).
Str("timeout", duration.String()).
Str("stderr", stderr.String()).
Str("stdout", stdout.String()).
Str("kind", kind).
Msg("Failed to start script")
return response, fmt.Errorf("script start failed script=%s kind=%s err=%w", lookPath, kind, err)
Expand All @@ -177,8 +175,6 @@ func (c *Credentials) execScript(cmdPath string, kind string, timeout string, e
c.logger.Error().Err(err).
Str("script", lookPath).
Str("timeout", duration.String()).
Str("stderr", stderr.String()).
Str("stdout", stdout.String()).
Str("kind", kind).
Msg("Failed to execute script")
return response, fmt.Errorf("script execute failed script=%s kind=%s err=%w", lookPath, kind, err)
Expand All @@ -190,8 +186,6 @@ func (c *Credentials) execScript(cmdPath string, kind string, timeout string, e
c.logger.Debug().Err(err).
Str("script", lookPath).
Str("timeout", duration.String()).
Str("stderr", stderr.String()).
Str("stdout", stdout.String()).
Str("kind", kind).
Msg("Failed to parse YAML output. Treating as plain text.")
}
Expand Down