feat: enable more golanglint linters

.golangci.yml

@@ -15,6 +15,7 @@ linters:
     - exhaustive
     - exportloopref
     - gocheckcompilerdirectives
+    - gochecksumtype
     - gocritic
     - gosec
     - gosimple
@@ -26,11 +27,13 @@ linters:
     - nolintlint
     - nonamedreturns
     - nosprintfhostport
+    - perfsprint
     - reassign
     - revive
     - staticcheck
     - stylecheck
     - tenv
+    - testifylint
     - thelper
     - testableexamples
     - typecheck

Makefile

@@ -86,6 +86,7 @@ ifeq (${LINT_EXISTS}, )
 	@exit 1
 endif
 	golangci-lint run
+	@cd integration && golangci-lint run
 
 govulncheck: ## run govulncheck on the source files
 ifeq (${GOVULNCHECK_EXISTS}, )

cmd/exporters/prometheus/httpd.go

@@ -25,7 +25,7 @@ func (p *Prometheus) startHTTPD(addr string, port int) {
 	mux.HandleFunc("/metrics", p.ServeMetrics)
 
 	server := &http.Server{
-		Addr:              addr + ":" + fmt.Sprint(port),
+		Addr:              addr + ":" + strconv.Itoa(port),
 		Handler:           mux,
 		ReadHeaderTimeout: 60 * time.Second,
 	}

integration/certer/main.go

@@ -187,7 +187,7 @@ func addCertificateAuthToHarvestUser() error {
 		if err != nil {
 			var oe models.OntapError
 			if errors.As(err, &oe) {
-				if oe.StatusCode == 409 {
+				if oe.StatusCode == http.StatusConflict {
 					// duplicate entry - that's fine, ignore
 					continue
 				}
@@ -355,7 +355,7 @@ func deleteCertificates(certificates models.Certificates) error {
 			Pathf("/api/security/certificates/%s", record.UUID).
 			ToString(&resp).
 			AddValidator(func(response *http.Response) error {
-				if response.StatusCode != 200 {
+				if response.StatusCode != http.StatusOK {
 					return fmt.Errorf("failed to delete ertificates. statusCode=%d status=%s", response.StatusCode, response.Status)
 				}
 				return nil

integration/test/installer/installer.go

@@ -26,7 +26,7 @@ func GetPerfFileWithQosCounters(source string, target string) string {
 	writeBuffer := bufio.NewWriter(writeFile)
 	file, err := os.Open(utils.GetHarvestRootDir() + "/" + source)
 	if err != nil {
-		log.Error().Err(err)
+		log.Error().Err(err).Send()
 	}
 	defer func(file *os.File) { _ = file.Close() }(file)
 
@@ -40,7 +40,7 @@ func GetPerfFileWithQosCounters(source string, target string) string {
 		_, _ = writeBuffer.WriteString(lineString + "\n")
 	}
 	if err := scanner.Err(); err != nil {
-		log.Error().Err(err)
+		log.Error().Err(err).Send()
 	}
 	_ = writeBuffer.Flush()
 	return modifiedFilePath

integration/test/utils/http_utils.go

@@ -28,12 +28,12 @@ func GetResponseBody(url string) ([]byte, error) {
 	if err != nil {
 		log.Fatalln(err)
 	}
-	defer resp.Body.Close()
 	body, err := io.ReadAll(resp.Body)
 	if err != nil {
 		log.Fatalln(err)
 		return nil, err
 	}
+	resp.Body.Close()
 	return body, nil
 }
 

integration/test/utils/utils.go

@@ -14,6 +14,7 @@ import (
 	"os/exec"
 	"path/filepath"
 	"runtime"
+	"strconv"
 	"strings"
 	"testing"
 	"time"
@@ -203,9 +204,12 @@ func CreateGrafanaToken() string {
 	log.Info().Msg("Creating grafana API Key.")
 	url := GetGrafanaHTTPURL() + "/api/auth/keys"
 	method := "POST"
-	name := fmt.Sprint(time.Now().Unix())
+	name := strconv.FormatInt(time.Now().Unix(), 10)
 	values := map[string]string{"name": name, "role": "Admin"}
-	jsonValue, _ := json.Marshal(values)
+	jsonValue, err := json.Marshal(values)
+	if err != nil {
+		panic(err)
+	}
 	data := SendReqAndGetRes(url, method, jsonValue)
 	key := fmt.Sprintf("%v", data["key"])
 	if len(key) > 0 {
@@ -310,7 +314,7 @@ func RemoveDuplicateStr(strSlice []string) []string {
 
 func SetupLogging() {
 	zerolog.SetGlobalLevel(zerolog.InfoLevel)
-	zerolog.ErrorStackMarshaler = MarshalStack
+	zerolog.ErrorStackMarshaler = MarshalStack //nolint:reassign
 	log.Logger = zerolog.New(zerolog.ConsoleWriter{Out: os.Stderr, NoColor: true}).
 		With().Caller().Stack().Timestamp().Logger()
 }