feat: smb2 restperf counters #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
cgrinds
approved these changes
Oct 11, 2023
|
Needs a release note since the RestPerf template does not have exact parity with the ZapiPerf template due to ONTAP impl |
Hardikl
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distinction between ZapiPerf and RestPerf is the additional
typelabel in ZapiPerf, which is derived from parsing theinstance_uuid.instance_uuidis missing in RestPerf. However, based on the dataset available in our clusters, it appears that thetypelabel may not be necessary.ZapiPerf:
smb2_tree_connect_latency{datacenter="VSIM",cluster="sti62nscluster-1",node="sti62-vsim-ucs140d",svm="vs0",type="kernel"} 0RestPerf:
smb2_session_setup_latency{datacenter="VSIM",cluster="sti62nscluster-1",node="sti62-vsim-ucs140d",svm="vs0"} 0