Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update href creation #2399

Merged
merged 10 commits into from
Oct 9, 2023
Merged

refactor: update href creation #2399

merged 10 commits into from
Oct 9, 2023

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 4, 2023
Hardikl
Hardikl reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@Hardikl Hardikl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endpoint() hasn't been used all places where it's required.

cmd/collectors/ems/ems.go Show resolved Hide resolved
cmd/collectors/ems/ems.go Show resolved Hide resolved
Hardikl
Hardikl previously approved these changes Oct 5, 2023
View reviewed changes
Hardikl
Hardikl previously approved these changes Oct 6, 2023
View reviewed changes
cgrinds
cgrinds reviewed Oct 6, 2023
View reviewed changes
cmd/tools/rest/HrefBuilder.go Outdated Show resolved Hide resolved
cmd/tools/rest/HrefBuilder.go Outdated Show resolved Hide resolved
cmd/tools/rest/HrefBuilder.go Outdated Show resolved Hide resolved
@rahulguptajss rahulguptajss marked this pull request as draft October 6, 2023 16:40
@rahulguptajss rahulguptajss marked this pull request as ready for review October 9, 2023 11:09
@rahulguptajss
Copy link
Contributor Author

Ready for review

cgrinds
cgrinds reviewed Oct 9, 2023
View reviewed changes
cmd/tools/rest/HrefBuilder.go Outdated Show resolved Hide resolved
cmd/tools/rest/HrefBuilder.go Outdated Show resolved Hide resolved
cgrinds
cgrinds reviewed Oct 9, 2023
View reviewed changes
cmd/tools/rest/rest.go Outdated Show resolved Hide resolved
@cgrinds cgrinds merged commit 304e684 into main Oct 9, 2023
9 checks passed
@cgrinds cgrinds deleted the rg2-with branch October 9, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds approved these changes

@Hardikl Hardikl Hardikl left review comments

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahulguptajss @cgrinds @Hardikl