Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "perf: Zapi allocs improvements (#2380)" #2389

Merged
merged 1 commit into from
Sep 29, 2023
Merged

revert: "perf: Zapi allocs improvements (#2380)" #2389

merged 1 commit into from
Sep 29, 2023

Conversation

rahulguptajss
Copy link
Contributor

This reverts commit 1489cfc.

Change done in #2380, reduces allocs but also increases parse time for xml payload due to streaming. Reverting the changes.

2023-09-29T01:59:40+05:30 INF collector/collector.go:485 > Collected Poller=dc-1 apiMs=15772 calcMs=0 collector=ZapiPerf:WorkloadDetailVolume instances=3360 metrics=20160 parseMs=37599 pluginMs=0 skips=0

@cla-bot cla-bot bot added the cla-signed label Sep 28, 2023
@cgrinds cgrinds merged commit 6890af2 into main Sep 29, 2023
9 checks passed
@cgrinds cgrinds deleted the rg2-revert branch September 29, 2023 10:47
@rahulguptajss rahulguptajss linked an issue Sep 29, 2023 that may be closed by this pull request
Analyze collectors for alloc and inuse memory improvements #2379
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hardikl Hardikl Hardikl approved these changes

@cgrinds cgrinds Awaiting requested review from cgrinds cgrinds is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analyze collectors for alloc and inuse memory improvements
3 participants
@rahulguptajss @Hardikl @cgrinds