feat: Tiering data changes for volume - template change #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hardikl
commented
Sep 4, 2023
•
Hardikl
commented
- volume template changes
- volume dashboard changes
- aggregare template changes
- aggregate dashboard changes
|
|
|
Aggregate Fabricpool Drilldown: Added new panels in Volume Statistics |
|
Updated list of rows for volume dashboard |
| request := node.NewXMLS("aggr-space-get-iter") | ||
| request.NewChildS("max-records", collectors.DefaultBatchSize) | ||
| if result, err = a.client.InvokeZapiCall(request); err != nil { | ||
| return aggrFootprintMap, err |
There was a problem hiding this comment.
return nil if error?
There was a problem hiding this comment.
If it's error, it would return empty map and it will skip block at line 74.
There was a problem hiding this comment.
Handled the error case
rahulguptajss
previously approved these changes
Sep 27, 2023
cgrinds
reviewed
Sep 28, 2023
cgrinds
previously approved these changes
Sep 29, 2023
rahulguptajss
previously approved these changes
Sep 29, 2023
rahulguptajss
previously approved these changes
Sep 29, 2023
cgrinds
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.