Convert to TypeScript / Add storybook #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megheaiulian
requested changes
Mar 27, 2024
| "@storybook/storybook-deployer": "^2.8.5", | ||
| "@storybook/web-components": "7.6.17", | ||
| "@types/mocha": "^10.0.6", | ||
| "@web/storybook-builder": "^0.1.9", |
There was a problem hiding this comment.
Isn't @web/storybook-builder and @web/storybook-framework-web-components enough ? Do we need to add all the @storybook/* plugin to deps?
src/cosmoz-treenode.ts
Outdated
| @@ -111,7 +142,7 @@ export const computePathToRender = (path, hideFromRoot, showMaxNodes) => { | |||
| ownerTree, | |||
| ellipsis = '… / ', | |||
| fallback, | |||
| }) => { | |||
| }: TreenodeType) => { | |||
There was a problem hiding this comment.
Since this i component I'd simply name this Props.
src/cosmoz-treenode.ts
Outdated
|
|
||
| export const computePathToRender = (path, hideFromRoot, showMaxNodes) => { | ||
| export type ComputePathTextType = { |
There was a problem hiding this comment.
We should not include the word Type in a type. We know its a type cause its TS.
There was a problem hiding this comment.
Since this uses some properties from Options we can reuse. See https://www.typescriptlang.org/docs/handbook/utility-types.html#picktype-keys
Suggested change
| export type ComputePathTextType = { | |
| export interface ComputePathText extends Pick<Props, 'ownerTree'|'ellipsis'| ...> { | |
| // add here own props that aren't the same | |
| pathToRender?: string | |
| } |
src/cosmoz-treenode.ts
Outdated
| text: string; | ||
| }; | ||
|
|
||
| export type TreenodeType = { |
|
|
||
| export const computePathToRender = ( | ||
| path?: string, | ||
| hideFromRoot?: number, |
There was a problem hiding this comment.
hideFromRoot and showMaxNodes can't be optional.
path also can't be optional but you can make it string|undefined.
Create it using treeJson loader
|
in favor of #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.