Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(footer): set max-toolbar-items when mini table is used #634

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

micaelagoffe
Copy link
Contributor

Set max-toolbar-items on cosmoz-bottom-bar when mini table is used

AB#17737

@micaelagoffe micaelagoffe requested a review from a team December 9, 2024 10:38
@micaelagoffe micaelagoffe self-assigned this Dec 9, 2024
lib/use-footer.js Outdated Show resolved Hide resolved
lib/use-footer.js Outdated Show resolved Hide resolved
@cristinecula
Copy link
Collaborator

Ideally the cosmoz-bottom-bar element would use intersection observers or some other mechanism to determine if it should show/hide the button.

@micaelagoffe micaelagoffe force-pushed the 17737-actions-collapsed-in-dropdown-when-mini branch from de9841c to b3b3b01 Compare December 9, 2024 14:40
lib/use-omnitable.js Outdated Show resolved Hide resolved
lib/render-footer.js Show resolved Hide resolved
@micaelagoffe micaelagoffe force-pushed the 17737-actions-collapsed-in-dropdown-when-mini branch from b3b3b01 to a5f9f57 Compare December 10, 2024 09:20
@micaelagoffe micaelagoffe force-pushed the 17737-actions-collapsed-in-dropdown-when-mini branch from a5f9f57 to 0b0549d Compare December 10, 2024 10:13
@cristinecula cristinecula merged commit 51b9f58 into master Dec 10, 2024
3 checks passed
@cristinecula cristinecula deleted the 17737-actions-collapsed-in-dropdown-when-mini branch December 10, 2024 10:35
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
## [13.14.1](v13.14.0...v13.14.1) (2024-12-10)

### Bug Fixes

* **footer:** set max-toolbar-items when mini table is used ([#634](#634)) ([51b9f58](51b9f58)), closes [AB#17737](https://github.com/AB/issues/17737)
Copy link

🎉 This PR is included in version 13.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants