Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset to factory omnitable #629

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

basilgood
Copy link
Contributor

Copy link
Collaborator

@cristinecula cristinecula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work investigating this! You have found the source of the issue, but the fix should be applied in the driver.

lib/settings/use-saved-settings.js Outdated Show resolved Hide resolved
lib/settings/use-saved-settings.js Outdated Show resolved Hide resolved
lib/settings/use-saved-settings.js Outdated Show resolved Hide resolved
@basilgood basilgood self-assigned this Sep 24, 2024
@basilgood basilgood added the bug label Sep 24, 2024
Copy link
Collaborator

@cristinecula cristinecula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename commit to use fix: not chore:

@cristinecula cristinecula merged commit 692a81e into master Sep 24, 2024
2 of 3 checks passed
@cristinecula cristinecula deleted the fix/reset-to-factory branch September 24, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants