Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(columns): added a minimum width to the status columns #593

Closed
wants to merge 1 commit into from

Conversation

CarloBar1
Copy link
Contributor

@CarloBar1 CarloBar1 commented Sep 11, 2023

Feature AB#10366 - set a minimum width for the status columns in omnitable.
image

@CarloBar1 CarloBar1 changed the title fix: added a minimum width to the status columns fix(columns): added a minimum width to the status columns Sep 11, 2023
@CarloBar1 CarloBar1 requested a review from a team September 12, 2023 07:32
@cristinecula
Copy link
Collaborator

Two problems:

  1. This will not work properly with the column resize algorithm. All widths need to be defined in JS, we can't use CSS for this. There are three properties that can be configured on the columns: width, minWidth and flex. These are the only way to control the width of the columns.
  2. cosmoz-omnitable should not be making such decisions. Defining a min width for columns named status or invoiceStatus has no place in this repo, which is a public component, meant to be usable in any project.

The correct solution is to change this in the tables configuration, in the views of cosmoz-frontend. Due to code duplication and legacy issues, this unfortunately means editing each and every place where a status column is defined. Please create a new PR in cosmoz-frontend, in which you set width (or minWidth) on the status columns.

@cristinecula cristinecula deleted the feature/ab10366 branch September 12, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants