Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: save settings locally #465

Merged
merged 1 commit into from
Oct 15, 2021
Merged

feat: save settings locally #465

merged 1 commit into from
Oct 15, 2021

Conversation

cristinecula
Copy link
Collaborator

Re RM:27156
Re #418

@cristinecula cristinecula requested a review from a team October 15, 2021 07:21
@cristinecula cristinecula self-assigned this Oct 15, 2021
megheaiulian
megheaiulian approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@megheaiulian megheaiulian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Very clean implementation.

Just a few minor comments ...

lib/use-saved-settings.js Outdated Show resolved Hide resolved
@cristinecula cristinecula force-pushed the feature/rm27156-save-settings branch from b790aaa to 738302a Compare October 15, 2021 09:10
@cristinecula cristinecula force-pushed the feature/rm27156-save-settings branch from 738302a to f636fc7 Compare October 15, 2021 09:10
megheaiulian
megheaiulian approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@megheaiulian megheaiulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cristinecula cristinecula merged commit d9e8304 into master Oct 15, 2021
@cristinecula cristinecula deleted the feature/rm27156-save-settings branch October 15, 2021 09:15
@github-actions
Copy link

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JockeCK JockeCK JockeCK approved these changes

@megheaiulian megheaiulian megheaiulian approved these changes

Assignees

@cristinecula cristinecula

Labels
enhancement high priority released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristinecula @megheaiulian @JockeCK