Improve autocomplete serialize, deserialize #149
Conversation
programmer4web
force-pushed
the
feature/NEOV-118-autocomplete-hash-serialize
branch
from
8041680 to
bb148c8
Compare
programmer4web
changed the title
programmer4web
force-pushed
the
feature/NEOV-118-autocomplete-hash-serialize
branch
2 times, most recently
from
2562c91 to
9c3f1e0
Compare
| @@ -158,6 +158,34 @@ | |||
| } | |||
| return true; | |||
| }); | |||
| }, | |||
|
|
|||
| _serializeFilter: function (obj = this.filter) { | |||
There was a problem hiding this comment.
- Use es6 syntax and skip
: function - Why
obj(more generic, harder to follow) and not something like justfilter?
(same below)
| return obj.split('~').map(item => this.values.find(v => { | ||
| const property = this.valueProperty; | ||
| if (!property) { | ||
| const vv = typeof v === 'number' ? v.toString() : v; |
There was a problem hiding this comment.
Why is this needed? Numbers should be able to compare directly, 3 === 3
There was a problem hiding this comment.
@nomego I changed to a _normalizeValue function because numbers from hash params are strings sometimes. If possible we convert to numbers.
megheaiulian
force-pushed
the
feature/NEOV-118-autocomplete-hash-serialize
branch
from
9c3f1e0 to
5cc6c9e
Compare
| if (!Array.isArray(this.values) || this._pendingFilterString) { | ||
| return; | ||
| } | ||
| this.setFilterFromHash(this._pendingFilterString); |
There was a problem hiding this comment.
_pendingFilterString can only be falsy? Intended? Where does that property even come from? New in this PR?
There was a problem hiding this comment.
@nomego The problem is that when we set filter (from deserializeFilter) values might not be set if data property is not set so it can't set selection in paper-autocomplete-chips.
Because of that I set the param from url as _pendingFilterString and next time values are set it will update filter.
There was a problem hiding this comment.
Another solution would be to able to set an array of values in cosmoz-autocomplete-chips.
programmer4web
force-pushed
the
feature/NEOV-118-autocomplete-hash-serialize
branch
from
5cc6c9e to
4cad5d1
Compare
programmer4web
force-pushed
the
feature/NEOV-118-autocomplete-hash-serialize
branch
from
4cad5d1 to
39fc3d8
Compare
programmer4web
changed the title
programmer4web
changed the title
_serializeFilter for example if valueProperty is id then in url will be only ids separated by ~
deserializeFilter splits ids and searches in column values for them and returns the items array.
Iulian: The problem is that when we set filter (from deserializeFilter) values might not be set if data property is not set so it can't set selection in paper-autocomplete-chips.
version 1: Because of that I set the param from url as _pendingFilterString and next time values are set it will update filter.
version 2: ( without flag ) set an array of values in paper-autocomplete-chips. [WIP]