Clear button element instead of iron-icon with class #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plequang
requested changes
Jan 8, 2018
ui-helpers/cosmoz-clear-button.html
Outdated
| width: 16px !important; | ||
| min-height: 16px; | ||
| height: 16px; | ||
| position: absolute; |
There was a problem hiding this comment.
position:absolute specifiies position from the edges of the closest relative ancestor.
In the filter dialog context, this ancestor is the paper-dialog-scrollable element, so the clear icon will always be on the top right of the dialog.
I guess it should be fixed with something like:
:host {
display: block;
position: relative
cosmoz-omnitable-column-amount.html
Outdated
| @@ -33,8 +35,7 @@ <h3 style="margin: 0;">[[ title ]]</h3> | |||
| </paper-input> | |||
| </div> | |||
| </paper-dropdown-menu> | |||
| <iron-icon icon="clear" class="header-clear-filter" | |||
| on-tap="resetFilter" visible$="[[ hasFilter(filter.*) ]]"></iron-icon> | |||
| <cosmoz-clear-button on-tap="resetFilter" hidden$="[[ !hasFilter(filter.*) ]]"></cosmoz-clear-button> | |||
There was a problem hiding this comment.
We can use click instead of tap event. See https://www.polymer-project.org/2.0/docs/devguide/gesture-events
cosmoz-omnitable-column-date.html
Outdated
| @@ -34,8 +35,7 @@ <h3 style="margin: 0;">[[ title ]]</h3> | |||
| </paper-input> | |||
| </div> | |||
| </paper-dropdown-menu> | |||
| <iron-icon icon="clear" class="header-clear-filter" | |||
| on-tap="resetFilter" visible$="[[ hasFilter(filter.*) ]]"></iron-icon> | |||
| <cosmoz-clear-button on-tap="resetFilter" hidden$="[[ !hasFilter(filter.*) ]]"></cosmoz-clear-button> | |||
| @@ -33,8 +34,7 @@ <h3 style="margin: 0;">[[ title ]]</h3> | |||
| </datetime-local> | |||
| </div> | |||
| </paper-dropdown-menu> | |||
| <iron-icon icon="clear" class="header-clear-filter" | |||
| on-tap="resetFilter" visible$="[[ hasFilter(filter.*) ]]"></iron-icon> | |||
| <cosmoz-clear-button on-tap="resetFilter" hidden$="[[ !hasFilter(filter.*) ]]"></cosmoz-clear-button> | |||
cosmoz-omnitable-column-number.html
Outdated
| @@ -28,8 +32,7 @@ <h3 style="margin: 0;">[[ title ]]</h3> | |||
| </paper-input> | |||
| </div> | |||
| </paper-dropdown-menu> | |||
| <iron-icon icon="clear" class="header-clear-filter" | |||
| on-tap="resetFilter" visible$="[[ hasFilter(filter.*) ]]"></iron-icon> | |||
| <cosmoz-clear-button on-tap="resetFilter" hidden$="[[ !hasFilter(filter.*) ]]"></cosmoz-clear-button> | |||
cosmoz-omnitable-column-time.html
Outdated
| @@ -30,8 +31,7 @@ <h3 style="margin: 0;">[[ title ]]</h3> | |||
| </paper-input> | |||
| </div> | |||
| </paper-dropdown-menu> | |||
| <iron-icon icon="clear" class="header-clear-filter" | |||
| on-tap="resetFilter" visible$="[[ hasFilter(filter.*) ]]"></iron-icon> | |||
| <cosmoz-clear-button on-tap="resetFilter" hidden$="[[ !hasFilter(filter.*) ]]"></cosmoz-clear-button> | |||
plequang
requested changes
Jan 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently needed to display the clear button in the filters-dialog (PR #90) without having to include the styles into the template.