Adds Safari bug comments

misc fixes
Neovici · Mar 16, 2019 · 698191c · 698191c
1 parent 35b17d5
commit 698191c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/cosmoz-omnitable-column-date-mixin.html b/cosmoz-omnitable-column-date-mixin.html
@@ -148,6 +148,9 @@
 		 * @return {String}                an ISO date string, with timezone info
 		 */
 		getAbsoluteISOString(localISOString) {
+			// Most browsers use local timezone when no timezone is specified
+			// but Safari uses UTC, so we set it implicitly
+			// TODO: Consider removing this when/if Safari handles local timezone correctly
 			if (localISOString.length === 19) {
 				return localISOString + this._getTimezoneString(localISOString);
 			}

diff --git a/cosmoz-omnitable-column-time.html b/cosmoz-omnitable-column-time.html
@@ -96,6 +96,9 @@ <h3 style="margin: 0;">[[ title ]]</h3>
 			 * @returns {Date|void}          Value converted to date optionaly limitated
 			 */
 			toDate(value, limit, limitFunc) {
+			// Most browsers use local timezone when no timezone is specified
+			// but Safari uses UTC, so we set it implicitly
+			// TODO: Consider removing this when/if Safari handles local timezone correctly
 				const date = typeof value === 'string' && value.length > 3 && value.length <= 9
 					? this.getAbsoluteISOString(this._fixedDate + 'T' + value)
 					: value;
@@ -142,8 +145,7 @@ <h3 style="margin: 0;">[[ title ]]</h3>
 				if (value == null) {
 					return;
 				}
-				value = this.getAbsoluteISOString(this._fixedDate + 'T' + value);
-				value = this.toValue(value);
+				value = this.toValue(this.getAbsoluteISOString(this._fixedDate + 'T' + value));
 				if (value == null) {
 					return;
 				}