Skip to content

Commit

Permalink
(patch) OmnitableRepeaterMixin._configureElement: code path is unreac…
Browse files Browse the repository at this point in the history
…hable

_configureElement expects to be called with a fresh element, so it can't have the `hidden` attribute set.
  • Loading branch information
cristinecula committed Mar 19, 2019
1 parent 3906d1c commit 444ed34
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions cosmoz-omnitable-repeater-mixin.html
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,7 @@
element.__column = column;

if (column === this.groupOnColumn) {
element.setAttribute('hidden', '');
} else if (element.hasAttribute('hidden')) {
element.removeAttribute('hidden', '');
element.setAttribute('hidden', true);
}

element.setAttribute('slot', this._slotName);
Expand Down

0 comments on commit 444ed34

Please sign in to comment.