fix: make the sizer take no height #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix provided by Iulian
|
megheaiulian
approved these changes
May 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
## [8.9.1](v8.9.0...v8.9.1) (2024-05-23) ### Bug Fixes * make the sizer take no height ([#173](#173)) ([2e3c3de](2e3c3de))
|
🎉 This PR is included in version 8.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the vertical scroll to take exactly the height of the items, not more.
Brief explanation: Virtualizer is based on the fact that
virtualizer-sizerelements have a height of 2px.When the
virtualizer-sizerelement has aline-heightgreater than 1 it adds the possibility of creating an overflow and then the vertical scroll doesn't match the height of the elements, it's bigger.