fix: drop unused hide-empty property

BREAKING CHANGE: hide-empty has been removed
Neovici · Nov 16, 2024 · 58d3829 · 58d3829
1 parent c241440
commit 58d3829
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 41 deletions.
diff --git a/src/autocomplete/autocomplete.ts b/src/autocomplete/autocomplete.ts
@@ -157,7 +157,6 @@ const autocomplete = <I>(props: AProps<I>) => {
 		'preserve-order',
 		'keep-opened',
 		'keep-query',
-		'hide-empty',
 		'default-index',
 		'item-height',
 		'item-limit',

diff --git a/src/autocomplete/use-autocomplete.ts b/src/autocomplete/use-autocomplete.ts
@@ -37,7 +37,6 @@ export interface Props<I> extends Base<I> {
 	textProperty?: string;
 	textual?: (prop?: string) => (i: I) => string;
 	valueProperty?: string;
-	hideEmpty?: boolean;
 	disabled?: boolean;
 	onFocus?: (focused?: boolean) => void;
 	preserveOrder?: boolean;
@@ -55,7 +54,6 @@ export const useAutocomplete = <I>({
 	textProperty,
 	textual: _textual,
 	valueProperty,
-	hideEmpty,
 	keepOpened,
 	keepQuery,
 	preserveOrder,
@@ -94,7 +92,6 @@ export const useAutocomplete = <I>({
 		empty,
 		limit,
 		value,
-		hideEmpty,
 		onChange,
 		onText,
 	});
@@ -122,9 +119,7 @@ export const useAutocomplete = <I>({
 		value,
 		source$,
 		items: useMemo(() => {
-			if (!active || (hideEmpty && empty)) {
-				return EMPTY;
-			}
+			if (!active) return EMPTY;
 
 			const items = preserveOrder
 				? options
@@ -136,7 +131,6 @@ export const useAutocomplete = <I>({
 			active,
 			query,
 			textual,
-			hideEmpty,
 			empty,
 			value,
 			preserveOrder,

diff --git a/src/autocomplete/use-keys.ts b/src/autocomplete/use-keys.ts
@@ -5,16 +5,15 @@ import { useMeta } from '@neovici/cosmoz-utils/hooks/use-meta';
 export interface Props<I> {
 	focused?: boolean;
 	empty?: boolean;
-	hideEmpty?: boolean;
 	value: I | I[];
 	limit?: number;
 	onChange: (v: I[]) => void;
 	onText: (s: string) => void;
 }
 
-export const useKeys = <I>({ focused, empty, ...info }: Props<I>) => {
+export const useKeys = <I>({ focused, empty, ...rest }: Props<I>) => {
 	const enabled = focused && empty,
-		meta = useMeta(info);
+		meta = useMeta(rest);
 	useEffect(() => {
 		if (!enabled) {
 			return;
@@ -32,13 +31,6 @@ export const useKeys = <I>({ focused, empty, ...info }: Props<I>) => {
 				(key === 'Backspace' || (isOne && key.length === 1))
 			) {
 				return meta.onChange(values.slice(0, -1));
-			} else if (
-				meta.hideEmpty &&
-				values.length < 1 &&
-				['Up', 'ArrowUp', 'Down', 'ArrowDown'].includes(key)
-			) {
-				meta.onText(' ');
-				e.preventDefault();
 			}
 		};
 

diff --git a/stories/cosmoz-autocomplete.stories.js b/stories/cosmoz-autocomplete.stories.js
@@ -30,7 +30,6 @@ const Autocomplete = ({
 	min,
 	label = '',
 	value = [],
-	hideEmpty = false,
 	disabled = false,
 	placeholder = '',
 	defaultIndex = 0,
@@ -59,7 +58,6 @@ const Autocomplete = ({
 			.value=${value}
 			.min=${min}
 			.defaultIndex=${defaultIndex}
-			?hide-empty=${hideEmpty}
 			?disabled=${disabled}
 			?show-single=${showSingle}
 			?preserve-order=${preserveOrder}
@@ -78,7 +76,6 @@ const ContourAutocomplete = ({
 	min,
 	label = '',
 	value = [],
-	hideEmpty = false,
 	disabled = false,
 	placeholder = '',
 	defaultIndex = 0,
@@ -119,7 +116,6 @@ const ContourAutocomplete = ({
 			.value=${value}
 			.min=${min}
 			.defaultIndex=${defaultIndex}
-			?hide-empty=${hideEmpty}
 			?disabled=${disabled}
 			?show-single=${showSingle}
 			?preserve-order=${preserveOrder}
@@ -156,7 +152,6 @@ export default {
 			control: 'number',
 			description: 'The default index of the source array',
 		},
-		hideEmpty: { control: 'boolean' },
 		disabled: {
 			control: 'boolean',
 			description:
@@ -218,24 +213,6 @@ export const Single = {
 	},
 };
 
-export const HideEmpty = {
-	args: {
-		label: 'Choose color',
-		source: colors,
-		textProperty: 'text',
-		limit: 1,
-		value: [colors[2]],
-		hideEmpty: true,
-	},
-	parameters: {
-		docs: {
-			description: {
-				story: 'Hide the empty value',
-			},
-		},
-	},
-};
-
 export const DefaultIndex = {
 	args: {
 		label: 'Choose color',