added rom cover support #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Two things: is the server fully operational now? The code is getting big, and I'm thinking about rewriting it in Python, to improve its portability. |
|
Hi man,
i moved to roms boxart to my own github repo (
https://github.com/DefKorns/rom-cover-generator/tree/master/boxart ).
The server that was hosting those boxart (for roms not nds games) belongs
to ModMyClassic team, and i dont want to be using it for non classic mini
related things. :)
I never worked with Python, i do a bit shellscript and my live is with
Typescript, Angular and dotNet Core.
I can try and help with it if you change it, but no guarantee :)
…On Sat, Sep 7, 2019 at 2:55 PM Death Mask Salesman ***@***.***> wrote:
Two things: is the server fully operational now?
The code is getting big, and I'm thinking about rewriting it in Python, to
improve its portability.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHYUXVA56AGZYIWSSO3Z5X3QIO6HRANCNFSM4ITA5JXA>
.
--
Com os melhores cumprimentos,
Marco Coelho
|
|
No problem, you help where you can. By the way, the commit history will still credit you, as well as the releases page, so your previous contributions will be recognized. |
|
For now, i'll continue to generate covers to no-intro rom set. And host
them on my github repo. This way we can have covers for all supported
systems.
Still missing, Super NES and Game Gear :)
…On Sat, Sep 7, 2019 at 6:02 PM Death Mask Salesman ***@***.***> wrote:
No problem, you help where you can.
By the way, the commit history will still credit you, as well as the
releases page, so your previous contributions will be recognized.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHYUXVFUU6UYE5ARQSED3HDQIPUDXANCNFSM4ITA5JXA>
.
--
Com os melhores cumprimentos,
Marco Coelho
|
|
@DMSalesman i tried to. But python is weird AF 😂 |
|
@DefKorns That's because Python designing is different than Bash designing. If I have time, I'll put together a |
|
@DMSalesman have you checked my It's working (may a need tuning), but still missing a couple of features:
|
|
I checked it, yes. I believe that it can be rewritten with improved command line args parsing, and I'll do so once I get some free time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the ability to check the crc32 from roms (no-intro set only) to find covers on custom server.
supports the following systems:
I only added covers for NES on my server, i'll update the other systems later