Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong caching in relative FqField construction #1952

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: wrong caching in relative FqField construction #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b1e9e8
fix: wrong caching in relative FqField construction
thofma Nov 28, 2024
3c7b1dd
chore: bump version
thofma Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Nemo"
uuid = "2edaba10-b0f1-5616-af89-8c11ac63239a"
version = "0.47.4"
version = "0.47.5"

[deps]
AbstractAlgebra = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"
Expand Down
2 changes: 1 addition & 1 deletion src/flint/fq_default_extended.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ function FqField(f::FqPolyRingElem, s::Symbol, cached::Bool = false, absolute::B
p = characteristic(K)
d = absolute_degree(K) * degree(f)
# Construct a "standard" copy of F_p^d
L = FqField(p, d, s, cached)
L = FqField(p, d, s, false)
L.isabsolute = absolute
L.isstandard = false
L.defining_poly = f
Expand Down
7 changes: 7 additions & 0 deletions test/flint/fq_default_extended-test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@
@test F(ZZ["x"][2] + 1) == b + 1
c = 2b^2 + 2b + 1
@test lift(Rx, c) == 2x^2 + 2x + 1

# fix for caching issues
R = GF(3, 2)
Rx, x = R["x"]
f = x
F, _ = finite_field(f, "b", cached = true)
@test F isa FqField
end

@testset "FqFieldElem.printing" begin
Expand Down
Loading