fix: univariate polynomial rings over zero rings #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe this one here first, then I could improve #1910 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1911 +/- ##
==========================================
- Coverage 88.17% 88.17% -0.01%
==========================================
Files 120 120
Lines 30298 30301 +3
==========================================
+ Hits 26716 26718 +2
- Misses 3582 3583 +1 ☔ View full report in Codecov by Sentry. |
lgoettgens
reviewed
Nov 25, 2024
| @@ -200,7 +200,7 @@ number_of_generators(R::PolyRing) = 1 | |||
|
|
|||
| iszero(a::PolynomialElem) = length(a) == 0 | |||
|
|
|||
| isone(a::PolynomialElem) = length(a) == 1 && isone(coeff(a, 0)) | |||
| isone(a::PolynomialElem) = length(a) <= 1 && isone(coeff(a, 0)) | |||
There was a problem hiding this comment.
does coeff(a, 0) even work for length(a) == 0 or does that error?
There was a problem hiding this comment.
Yes it works. This is part of the interface https://nemocas.github.io/AbstractAlgebra.jl/stable/poly_interface/#Basic-manipulation-of-rings-and-elements.
fingolfin
reviewed
Nov 25, 2024
|
I will keep the caching of triviality for now. We can remove it later if we want. |
Co-authored-by: Max Horn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.