Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise == and isequal for ring elements #1854

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Revise == and isequal for ring elements #1854

wants to merge 6 commits into from

Commits on Oct 11, 2024

  1. Default == and isequal for NCRingElem

    @fingolfin
    fingolfin committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a30f7c4 View commit details
    Browse the repository at this point in the history

  2. Replace some custom checks by check_parent

    @fingolfin
    fingolfin committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    db82bbc View commit details
    Browse the repository at this point in the history

  3. Delete redundant isequal method 

    The default method already delegates to ==
    @fingolfin
    fingolfin committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4ef9fc7 View commit details
    Browse the repository at this point in the history

  4. Fix isequal for RationalFunctionFieldElem 

    ... to delegate to isequal for the data
    @fingolfin
    fingolfin committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fd7aa4e View commit details
    Browse the repository at this point in the history

  5. Strict parent checks in == methods

    @fingolfin
    fingolfin committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    260d487 View commit details
    Browse the repository at this point in the history

  6. Lax parent checks in isequal methods 

    Since isequal is called for e.g. keys in dictionaries, it
makes sense to allow comparing rings with different parents,
and reporting them as being non-equal
    @fingolfin
    fingolfin committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0a069dc View commit details
    Browse the repository at this point in the history