Merge MatSpace and Generic.MatSpace #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1849 +/- ##
==========================================
+ Coverage 88.15% 88.16% +0.01%
==========================================
Files 119 120 +1
Lines 30017 30009 -8
==========================================
- Hits 26460 26456 -4
+ Misses 3557 3553 -4 ☔ View full report in Codecov by Sentry. |
fingolfin
approved these changes
Oct 8, 2024
|
No, it is good idea. |
|
Discussed it in triage and got no objections |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1840.
This should technically be non-breaking as
Generic.MatSpace === MatSpaceafter these changes, and thus all references toGeneric.MatSpacestill point to the actual type used for matrix spaces. In the next breaking release, we can uncomment the deprecation to fade out the use ofGeneric.MatSpace.I haven't tested this with Nemo yet, let's hope for the best.