-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_finite
methods for various ring types
#1842
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1842 +/- ##
==========================================
- Coverage 88.14% 88.10% -0.04%
==========================================
Files 120 120
Lines 30019 30031 +12
==========================================
- Hits 26459 26458 -1
- Misses 3560 3573 +13 ☔ View full report in Codecov by Sentry. |
@lgoettgens improved it. note that lots of other things are broken for (m)poly/series/... rings over zero rings, e.g. This could be fixed at the price of making
Anyway I won't resolve that here. I am still tempted to say "zero rings as coefficient rings are verboten and either outright rejected or lead to undefined behaviors" ... |
b639db9
to
45fef08
Compare
Also add missing (but documented) `characteristic` method for `FreeAssociativeAlgebra`
45fef08
to
791f95f
Compare
Also add missing (but documented)
characteristic
method forFreeAssociativeAlgebra