Fix Strassen, add a test #1803
Merged
Fix Strassen, add a test #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1803 +/- ##
=======================================
Coverage 88.02% 88.02%
=======================================
Files 119 119
Lines 30057 30057
=======================================
Hits 26457 26457
Misses 3600 3600 ☔ View full report in Codecov by Sentry. |
|
https://github.com/Nemocas/AbstractAlgebra.jl/pull/1803/files shows an error for me. Is this an artifact? |
I think so. The job itself succeeded. I nevertheless restarted CI to make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Strassen, which I broke in #1784, and adds a corresponding "real" doctest.
This requires #1801 to be merged first to work properly.