Add applicable
check to @show_special
#1595
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1583 by @joschmitt.
This contains the changes from #1594 to avoid conflicts. The changes of this PR are solely contained in the last commit.
This change enables us to use the
@show_special
macro with both signatures (with/without MIME type) extensively without the need to make sure that both dispatches exist for allshow_*
functions. The macro now only does something if the custom show function matches the signature of the macro.(I cannot choose @joschmitt as a reviewer, but please have a look as well.)