Improve with_unicode #1495
Improve with_unicode #1495
Conversation
src/AbstractAlgebra.jl
Outdated
| # remove the following, once they land in OSCAR | ||
| :allow_unicode, :with_unicode, |
There was a problem hiding this comment.
@thofma I am not 100% sure I am reading this comment right: it seems we can remove these two lines here at some point ... and allow_unicode, with_unicode sure are in Oscar... But can we just remove this here, won't it lead to nasty warnings in Oscar about methods being redefined? Anyway, if that's the case, we could just mark this PR as "breaking", I guess?
There was a problem hiding this comment.
Hm, I think the idea was to remove Oscar.allow_unicode and Oscar.with_unicode and use the corresponding AA functions (by importing them explicitly in Oscar).
There was a problem hiding this comment.
OK that makes more sense. Then we should first update Oscar accordingly. I've adjusted this PR to only update with_unicode
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
=======================================
Coverage 86.86% 86.87%
=======================================
Files 110 110
Lines 28668 28669 +1
=======================================
+ Hits 24903 24905 +2
+ Misses 3765 3764 -1
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Some time ago `with_unicode` was improved in Oscar, apply that here.
fingolfin
changed the title
Some time ago `with_unicode` was improved in Oscar, apply that here.
Some time ago
with_unicodewas improved in Oscar, apply that here.